From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 3/3] mem: improve autodetection of hugepage counts on 32-bit Date: Fri, 27 Apr 2018 23:47:11 +0200 Message-ID: <4370618.qW8ombCSU7@xps> References: <3AEA2BF9852C6F48A459DA490692831F2A2C9B5B@irsmsx110.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Pattan, Reshma" , "Parthasarathy, JananeeX M" To: "Burakov, Anatoly" Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 739955F16 for ; Fri, 27 Apr 2018 23:47:14 +0200 (CEST) In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A2C9B5B@irsmsx110.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > For non-legacy mode, we are preallocating space for hugepages, so we know > > in advance which pages we will be able to allocate, and which we won't. > > However, the init procedure was using hugepage counts gathered from sysfs > > and paid no attention to hugepage sizes that were actually available for > > reservation, and failed on attempts to reserve unavailable pages. > > > > Fix this by limiting total page counts by number of pages actually > > preallocated. > > > > Also, VA preallocate procedure only looks at mountpoints that are available, > > and expects pages to exist if a mountpoint exists. That might not necessarily > > be the case, so also check if there are hugepages available for a particular > > page size on a particular NUMA node. > > > > Signed-off-by: Anatoly Burakov > > Tested-by: Jananee Parthasarathy Series applied, thanks