From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] examples/ip_pipeline: fix RSS
Date: Sun, 05 Aug 2018 22:08:28 +0200
Message-ID: <4382199.Nx38v1RVeE@xps>
References: <1533048565-216267-1-git-send-email-cristian.dumitrescu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Fan Zhang <roy.fan.zhang@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Yuan Peng <yuan.peng@intel.com>
To: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 2C5411B583
 for <dev@dpdk.org>; Sun,  5 Aug 2018 22:11:53 +0200 (CEST)
In-Reply-To: <1533048565-216267-1-git-send-email-cristian.dumitrescu@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

31/07/2018 16:49, Cristian Dumitrescu:
> Fix for RSS issue triggered by latest changes in ethdev layer.
> 
> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Collected agreements:
    Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
    Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
    Tested-by: Yuan Peng <yuan.peng@intel.com>

But 3 things are missing:
	- The issue is not described
	- The fix is not explained (you chose to mask unsupported RSS fields)
	- There is no Fixes line, I guess this one:
		Fixes: aa1a6d87f15d ("ethdev: force RSS offload rules again")

Please send a v2