From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] telemetry: fix shared build for make Date: Fri, 9 Nov 2018 22:19:36 +0000 Message-ID: <438ce75d-7bf6-1845-2303-d3151e0a71bf@intel.com> References: <20181107181018.80224-1-kevin.laatz@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: harry.van.haaren@intel.com, gaetan.rivet@6wind.com, thomas@monjalon.net, mattias.ronnblom@ericsson.com, bruce.richardson@intel.com, radu.nicolau@intel.com, ciara.power@intel.com, brian.archbold@intel.com To: Kevin Laatz , dev@dpdk.org Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id E62222BE5 for ; Fri, 9 Nov 2018 23:19:39 +0100 (CET) In-Reply-To: <20181107181018.80224-1-kevin.laatz@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/7/2018 6:10 PM, Kevin Laatz wrote: > Currently, telemetry is not working for shared builds in make. > > The --as-needed flag is preventing telemetry from being linked as there are > no direct API calls from the app to telemetry. This is causing the > --telemetry option to not be recognized by EAL. > Telemetry registers it's EAL option using the RTE_INIT constructor. Since > EAL's option parsing is done before the plugins init, the --telemetry > option isn't registered at the time of parsing, and as a result, the > --telemetry option is not being recognized. > > This patch fixes this issue by explicitly linking telemetry to the > application by setting the "--no-as-needed" flag for the library in > mk/rte.app.mk. > > Fixes: 8877ac688b52 ("telemetry: introduce infrastructure") > > Reported-by: Yanjie Xu > Signed-off-by: Kevin Laatz Reviewed-by: Ferruh Yigit