From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] virtio: fix wrong features returned for legacy virtio Date: Mon, 14 Mar 2016 23:21:04 +0100 Message-ID: <4392228.eN2PaL5BSa@xps13> References: <1457593280-25412-1-git-send-email-yuanhan.liu@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, David Marchand To: Yuanhan Liu Return-path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 0EE785323 for ; Mon, 14 Mar 2016 23:22:29 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id l68so2315581wml.1 for ; Mon, 14 Mar 2016 15:22:29 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-10 08:43, David Marchand: > On Thu, Mar 10, 2016 at 8:01 AM, Yuanhan Liu > wrote: > > Declare dst as type uint32_t instead of uint64_t, otherwise, we will get > > a random upper 32 bit feature bits, as the following io port read reads > > lower 32 bit only. It could lead a feature bits that include VIRTIO_F_VERSION_1 > > (the 32th bit) for legacy virtio, which is obviously wrong. > > > > Fixes: b8f04520ad71 ("virtio: use PCI ioport API") > > > > Cc: David Marchand > > Signed-off-by: Yuanhan Liu > > Argh, good catch. > Relooked at my patch, this should be the only bug (of this kind ;-)). > > Reviewed-by: David Marchand Applied, thanks