From mboxrd@z Thu Jan 1 00:00:00 1970 From: Akhil Goyal Subject: Re: [PATCH 5/6] cryptodev: remove old get session size functions Date: Thu, 21 Jun 2018 18:29:27 +0530 Message-ID: <43fc9297-2e7e-7a23-c7d9-7eaab3e0d134@nxp.com> References: <20180608220234.10170-1-pablo.de.lara.guarch@intel.com> <20180608220234.10170-6-pablo.de.lara.guarch@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Pablo de Lara , declan.doherty@intel.com, ravi1.kumar@amd.com, jerin.jacob@caviumnetworks.com, roy.fan.zhang@intel.com, fiona.trahe@intel.com, tdu@semihalf.com, jianjay.zhou@huawei.com Return-path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00081.outbound.protection.outlook.com [40.107.0.81]) by dpdk.org (Postfix) with ESMTP id 5720F1B5C0 for ; Thu, 21 Jun 2018 14:59:46 +0200 (CEST) In-Reply-To: <20180608220234.10170-6-pablo.de.lara.guarch@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Pablo, On 6/9/2018 3:32 AM, Pablo de Lara wrote: > Removed rte_cryptodev_get_header_session_size > and rte_cryptodev_get_private_session_size functions, > as they have been substituted with functions > specific for symmetric operations, with _sym_ word > after "rte_cryptodev_". > > Signed-off-by: Pablo de Lara > --- > doc/guides/rel_notes/deprecation.rst | 6 ------ > doc/guides/rel_notes/release_18_08.rst | 8 ++++++++ > lib/librte_cryptodev/rte_cryptodev.c | 6 ------ > lib/librte_cryptodev/rte_cryptodev.h | 11 ----------- > lib/librte_cryptodev/rte_cryptodev_version.map | 2 -- > 5 files changed, 8 insertions(+), 25 deletions(-) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 91592534e..9a73b1d8e 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -107,9 +107,3 @@ Deprecation Notices > with them. > - Some feature flags such as ``RTE_CRYPTODEV_FF_MBUF_SCATTER_GATHER`` are ambiguous, > so some will be replaced by more explicit flags. > - - Function ``rte_cryptodev_get_header_session_size()`` will be deprecated > - in 18.05, and it gets replaced with ``rte_cryptodev_sym_get_header_session_size()``. > - It will be removed in 18.08. > - - Function ``rte_cryptodev_get_private_session_size()`` will be deprecated > - in 18.05, and it gets replaced with ``rte_cryptodev_sym_get_private_session_size()``. > - It will be removed in 18.08. > diff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes/release_18_08.rst > index 3fa9a6e68..0624f3701 100644 > --- a/doc/guides/rel_notes/release_18_08.rst > +++ b/doc/guides/rel_notes/release_18_08.rst > @@ -64,6 +64,14 @@ API Changes > - ``rte_cryptodev_queue_pair_start`` > - ``rte_cryptodev_queue_pair_stop`` > > +* cryptodev: Following functions were deprecated and are replaced by > + other functions in 18.08: > + > + - ``rte_cryptodev_get_header_session_size`` is replaced with > + ``rte_cryptodev_sym_get_header_session_size`` > + - ``rte_cryptodev_get_private_session_size`` is replaced with > + ``rte_cryptodev_sym_get_private_session_size`` > + rte_cryptodev_get_private_session_size is not removed in this patch. I think you missed it in your patch. -Akhil > > ABI Changes > ----------- > diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c > index a07904fb9..40e249e79 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.c > +++ b/lib/librte_cryptodev/rte_cryptodev.c > @@ -1181,12 +1181,6 @@ rte_cryptodev_sym_session_free(struct rte_cryptodev_sym_session *sess) > return 0; > } > > -unsigned int > -rte_cryptodev_get_header_session_size(void) > -{ > - return rte_cryptodev_sym_get_header_session_size(); > -} > - > unsigned int > rte_cryptodev_sym_get_header_session_size(void) > { > diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h > index 90487bffc..8e8a59522 100644 > --- a/lib/librte_cryptodev/rte_cryptodev.h > +++ b/lib/librte_cryptodev/rte_cryptodev.h > @@ -925,17 +925,6 @@ int > rte_cryptodev_sym_session_clear(uint8_t dev_id, > struct rte_cryptodev_sym_session *sess); > > -/** > - * @deprecated > - * Get the size of the header session, for all registered drivers. > - * > - * @return > - * Size of the header session. > - */ > -__rte_deprecated > -unsigned int > -rte_cryptodev_get_header_session_size(void); > - > /** > * @deprecated > * Get the size of the private session data for a device. > diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map b/lib/librte_cryptodev/rte_cryptodev_version.map > index 020b45754..0ab6d5195 100644 > --- a/lib/librte_cryptodev/rte_cryptodev_version.map > +++ b/lib/librte_cryptodev/rte_cryptodev_version.map > @@ -63,8 +63,6 @@ DPDK_17.08 { > rte_cryptodev_driver_id_get; > rte_cryptodev_driver_name_get; > rte_cryptodev_get_aead_algo_enum; > - rte_cryptodev_get_header_session_size; > - rte_cryptodev_get_private_session_size; > rte_cryptodev_sym_capability_check_aead; > rte_cryptodev_sym_session_init; > rte_cryptodev_sym_session_clear;