From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4 10/10] doc: add IPsec library guide
Date: Wed, 19 Dec 2018 04:46:07 +0100
Message-ID: <4415749.u5Xr9rgFO6@xps>
References: <1544110714-4514-2-git-send-email-konstantin.ananyev@intel.com>
 <1544804878-11920-1-git-send-email-konstantin.ananyev@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Bernard Iremonger <bernard.iremonger@intel.com>,
 marko.kovacevic@intel.com
To: Konstantin Ananyev <konstantin.ananyev@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
 [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id A1B1C1B589
 for <dev@dpdk.org>; Wed, 19 Dec 2018 04:46:11 +0100 (CET)
In-Reply-To: <1544804878-11920-1-git-send-email-konstantin.ananyev@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

14/12/2018 17:27, Konstantin Ananyev:
> Add IPsec library guide and update release notes.

A quick look at the guide hint me that you should check the spelling.

> --- a/doc/guides/rel_notes/release_19_02.rst
> +++ b/doc/guides/rel_notes/release_19_02.rst
> @@ -60,6 +60,16 @@ New Features
> +* **Added IPsec Library.**
> +
> +  Added an experimental library ``librte_ipsec`` to provide ESP tunnel and
> +  transport support for IPv4 and IPv6 packets.
> +
> +  The library provides support for AES-CBC ciphering and AES-CBC with HMAC-SHA1
> +  algorithm-chaining, and AES-GCM and NULL algorithms only at present. It is
> +  planned to add more algorithms in future releases.
> +
> +  See :doc:`../prog_guide/ipsec_lib` for more information.
>  
>  Removed Items
>  -------------

Please keep the spacing (2 blank lines before heading).

I've seen other minor spacing mistakes in other patches.
Please check, thanks.