From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] service: fix build error "ids
	uninitialized in rte_service_map_lcore_set"
Date: Thu, 21 Sep 2017 14:41:46 +0200
Message-ID: <4430088.xROSz6HfYO@xps>
References: <1505958643-21203-1-git-send-email-yi.y.yang@intel.com>
 <E923DB57A917B54B9182A2E928D00FA650FA8738@IRSMSX101.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, "Van Haaren, Harry" <harry.van.haaren@intel.com>,
 nelio.laranjeiro@6wind.com
To: "Yang, Yi Y" <yi.y.yang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 6FEB47D4E
 for <dev@dpdk.org>; Thu, 21 Sep 2017 14:41:48 +0200 (CEST)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA650FA8738@IRSMSX101.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

21/09/2017 13:55, Van Haaren, Harry:
> > From: Yang, Yi Y
> > Sent: Thursday, September 21, 2017 2:51 AM
> > To: dev@dpdk.org
> > Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; Yang, Yi Y
> > <yi.y.yang@intel.com>
> > Subject: [PATCH v2] service: fix build error "ids uninitialized in
> > rte_service_map_lcore_set"
> >=20
> > v1->v2
> >   - Change title to more descriptive one
> >   - Add issue reproduce information to git log body
> >=20
> > On current master tree, normal DPDK make will result in
> > the below error:
> >=20
> >     error: =E2=80=98ids[0]=E2=80=99 may be used uninitialized in this
> >     function [-Werror=3Dmaybe-uninitialized]
> >     ret =3D rte_service_map_lcore_set(i, ids[lcore_iter], 1);
> >=20
> > It can be reproduced very easily on Fedora 21 with
> > gcc-4.9.2-6.fc21.x86_64.

=46ixes: 21698354c832 ("service: introduce service cores concept")
Cc: stable@dpdk.org

> > It is fixed after applied this patch.
> >=20
> > Signed-off-by: Yi Yang <yi.y.yang@intel.com>
>=20
> +CC Thomas, please pull this asap, as it causes build issues on various G=
CC/OS versions.

Most of compilers do not raise an error.
It seems specific to gcc 4.9.
Nelio reported the same error with gcc 4.9.
Changing the title to "service: fix build with gcc 4.9"

> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

Applied, thanks