From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4 0/4] bonding corrections and additions Date: Mon, 29 Jun 2015 00:02:38 +0200 Message-ID: <4434114.84Vb6lbvqE@xps13> References: <1432654909-13845-1-git-send-email-ehkinzie@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: nhorman@tuxdriver.com, declan.doherty@intel.com Return-path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 6465AC448 for ; Mon, 29 Jun 2015 00:03:47 +0200 (CEST) Received: by wgqq4 with SMTP id q4so126734055wgq.1 for ; Sun, 28 Jun 2015 15:03:47 -0700 (PDT) In-Reply-To: <1432654909-13845-1-git-send-email-ehkinzie@gmail.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Declan, Neil, Please help to review this series. 2015-05-26 08:41, Eric Kinzie: > This patchset makes a couple of small corrections to the bonding driver > and introduces the ability to use an external state machine for mode > 4 operation. > > Changes in v2: > . eliminate external_sm field in 802.3ad configuration > (rte_eth_bond_8023ad_conf). > . stop bonding device before changing the periodic callback function. > start again if needed. > . remove unnecessary calls to valid_bonded_port_id(). > . do not check for NULL tx_ring. > . return error in rte_eth_bond_8023ad_ext_slowtx() if packet is not LACP. > . remove check for external sm configuration in periodic callback > . check for valid LACPDU in test application's rx callback > . add "Fixes:" tags > > Changes in v3: > . update rte_eth_bond_version.map > > Changes in v4: > . version functions that modify slowrx_cb > > Eric Kinzie (4): > bond mode 4: copy entire config structure > bond mode 4: do not ignore multicast > bond mode 4: allow external state machine > bond mode 4: tests for external state machine > > app/test/test_link_bonding_mode4.c | 217 ++++++++++++++++++- > drivers/net/bonding/Makefile | 2 +- > drivers/net/bonding/rte_eth_bond_8023ad.c | 241 ++++++++++++++++++++- > drivers/net/bonding/rte_eth_bond_8023ad.h | 44 ++++ > drivers/net/bonding/rte_eth_bond_8023ad_private.h | 28 +++ > drivers/net/bonding/rte_eth_bond_pmd.c | 1 + > drivers/net/bonding/rte_eth_bond_version.map | 7 + > 7 files changed, 524 insertions(+), 16 deletions(-) > >