From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 00/10] standard make install
Date: Wed, 02 Dec 2015 10:25:14 +0100
Message-ID: <4473021.fPPR1HZVLV@xps13>
References: <1449028676-19232-1-git-send-email-thomas.monjalon@6wind.com>
 <565EA15A.1080902@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Panu Matilainen <pmatilai@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id 14BFC8E58
 for <dev@dpdk.org>; Wed,  2 Dec 2015 10:26:24 +0100 (CET)
Received: by wmuu63 with SMTP id u63so206348987wmu.0
 for <dev@dpdk.org>; Wed, 02 Dec 2015 01:26:24 -0800 (PST)
In-Reply-To: <565EA15A.1080902@redhat.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-12-02 09:44, Panu Matilainen:
> That aside, a bigger problem is that it doesn't seem to work.
> 
> make clean
> make config T=x86_64-native-linuxapp-gcc
> make
> make install DESTDIR=/tmp/dpdk-root

Oh, I forgot to test the simple case where O= is not specified!

It should be fixed with this change:

--- a/mk/rte.sdkinstall.mk
+++ b/mk/rte.sdkinstall.mk
@@ -31,8 +31,10 @@
 #   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 # Build directory is given with O=
-O ?= .
+ifndef T
+O ?= build
 BUILD_DIR := $O
+endif
 
 prefix      ?=     /usr/local
 exec_prefix ?=      $(prefix)
@@ -52,6 +54,7 @@ sdkdir      ?= $(datadir)
 # with make install T=<config>
 ifdef T
 # The build directory is T and may be prepended with O
+O ?= .
 BUILD_DIR := $O/$T
 # Default usage of T= will install an almost flat staging tree
 export prefix =