From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] examples/l3fwd: em path performance fix Date: Tue, 15 Mar 2016 15:49:34 +0100 Message-ID: <4500844.l7uGIisiEg@xps13> References: <1457441937-2176-1-git-send-email-tomaszx.kulasek@intel.com> <3042915272161B4EB253DA4D77EB373A14E6B4B1@IRSMSX102.ger.corp.intel.com> <3042915272161B4EB253DA4D77EB373A14E6BDDA@IRSMSX102.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org To: "Kulasek, TomaszX" , Maciej Czekaj Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 845755596 for ; Tue, 15 Mar 2016 15:51:00 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id l68so148538354wml.0 for ; Tue, 15 Mar 2016 07:51:00 -0700 (PDT) In-Reply-To: <3042915272161B4EB253DA4D77EB373A14E6BDDA@IRSMSX102.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-15 14:31, Kulasek, TomaszX: > From: Kulasek, TomaszX > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > There is an error: > > > examples/l3fwd/l3fwd_em_hlm_sse.h:72:38: error: > > > =09incompatible type for argument 2 of =E2=80=98_mm_and_si128=E2=80= =99 > >=20 > > It's caused by > >=20 > > commit 64d3955de1de4d7879a0930a6d2f501369d3445a > > Author: Maciej Czekaj > > Date: Thu Mar 10 17:06:22 2016 +0100 > >=20 > > examples/l3fwd: fix ARM build > >=20 > > Enable NEON support in exact match mode. > > l3fwd example did not compile on ARM due to SSE2 instrincics us= ed > > in generic part. > > Some instrinsins were used to initialize data structures and th= ose > > were > > replaced by ordinary structure initalization. > > All SSE2 intrinsics used in forwarding, i.e. masking the IP/TCP= header > > are moved to single inline function and made arch-specific. > >=20 > > Signed-off-by: Maciej Czekaj = > >=20 > > Which doesn't include rework of l3fwd_em_hlm_sse.h file. > >=20 > > When you compile it now with global "#define HASH_MULTI_LOOKUP 1" a= nd > > alternative classification is used, and compilation will also fail = now. > >=20 > > I need a little bit more time to investigate it, because I'm not an= expert > > in ARM. It will be nice if Maciej will help me in that. > >=20 > > Tomasz >=20 > Will be that ok for you to disable this path for arm? Please, what do you mean? Maciej, have you looked at this issue?