From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v8 1/9] eal/bus: introduce bus abstraction
Date: Wed, 18 Jan 2017 00:19:49 +0100
Message-ID: <4512536.CCfCtgmVzb@xps13>
References: <1484647774-28984-1-git-send-email-shreyansh.jain@nxp.com>
 <1484660264-6531-1-git-send-email-shreyansh.jain@nxp.com>
 <1484660264-6531-2-git-send-email-shreyansh.jain@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id 0C07F11DE
 for <dev@dpdk.org>; Wed, 18 Jan 2017 00:19:51 +0100 (CET)
Received: by mail-wm0-f51.google.com with SMTP id f73so42708016wmf.1
 for <dev@dpdk.org>; Tue, 17 Jan 2017 15:19:51 -0800 (PST)
In-Reply-To: <1484660264-6531-2-git-send-email-shreyansh.jain@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-01-17 19:07, Shreyansh Jain:
> +void
> +rte_bus_register(struct rte_bus *bus)
> +{
> +	RTE_VERIFY(bus);
> +	RTE_VERIFY(bus->name && strlen(bus->name));
> +
> +	TAILQ_INSERT_TAIL(&rte_bus_list, bus, next);
> +	RTE_LOG(INFO, EAL, "Registered [%s] bus.\n", bus->name);

I think it should be a debug log.

> +/* unregister a bus */
> +void
> +rte_bus_unregister(struct rte_bus *bus)

I appreciate the effort for commenting, but I think the function name
is self describing.

> +/**
> + * @file
> + *
> + * RTE PMD Bus Abstraction interfaces

RTE PMD?
I would say "DPDK device bus interface"

> +DPDK_17.02 {
> +	global:
> +
> +	rte_bus_list;

Why the bus list is exported?
If it is for testing purpose, I wonder wether it is worth to do it.