From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3] eal: add counter size for efd clean
Date: Wed, 11 Oct 2017 15:11:03 +0200
Message-ID: <4513487.fCd9laRvq9@xps>
References: <1502636600-46889-1-git-send-email-jingjing.wu@intel.com>
 <1503540656-104421-1-git-send-email-jingjing.wu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, jianfeng.tan@intel.com, shreyansh.jain@nxp.com,
 hemant.agrawal@nxp.com, santosh.shukla@caviumnetworks.com,
 Tomasz Duszynski <tdu@semihalf.com>, Jacek Siuda <jck@semihalf.com>,
 jerin.jacob@caviumnetworks.com
To: Jingjing Wu <jingjing.wu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 7A6E6F1F
 for <dev@dpdk.org>; Wed, 11 Oct 2017 15:11:05 +0200 (CEST)
In-Reply-To: <1503540656-104421-1-git-send-email-jingjing.wu@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

24/08/2017 04:10, Jingjing Wu:
>         } else if (intr_handle->type == RTE_INTR_HANDLE_VDEV) {
> -               /* do nothing, and let vdev driver to initialize this struct */
> +               /* only check, initialization would be done in vdev driver.*/
> +               if (intr_handle->efd_counter_size >
> +                   sizeof(union rte_intr_read_buffer)) {
> +                       RTE_LOG(ERR, EAL, "the efd_counter_size is oversized");
> +                       return -EINVAL;
> +               }

How interrupts are working with other buses?

Is it something we should manage in bus drivers code?