From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] i40e: correct the private data size for i40e
	vf driver
Date: Tue, 28 Jul 2015 10:11:13 +0200
Message-ID: <4517043.MQg1LVTXME@xps13>
References: <1438046019-30149-1-git-send-email-jingjing.wu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Jingjing Wu <jingjing.wu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com
 [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id A0FABC320
 for <dev@dpdk.org>; Tue, 28 Jul 2015 10:12:30 +0200 (CEST)
Received: by wicgb10 with SMTP id gb10so144761891wic.1
 for <dev@dpdk.org>; Tue, 28 Jul 2015 01:12:30 -0700 (PDT)
In-Reply-To: <1438046019-30149-1-git-send-email-jingjing.wu@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Jingjing,

Few comments about the patch message.
The title must tell what issue is fixed, e.g. "fix crash when...".
the end "for i40e vf driver" is useless if it starts with "i40evf:".

2015-07-28 09:13, Jingjing Wu:
> The patch fixes the i40e VF crash issue. The issue's root cause is that
> the dev_private_size in i40e virtual function driver struct
> rte_i40evf_pmd was set incorrectly.

Please explain what are the conditions of the crash
and give a reference to the commit introducing the error with "Fixes: ...".

> Signed-off-by: jingjing.wu <jingjing.wu@intel.com>

Thanks