From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] net/sfc: add missing Rx descriptor status callback Date: Wed, 30 May 2018 12:30:28 +0200 Message-ID: <4525103.1gb9Ugr6pG@xps> References: <1527490247-23324-1-git-send-email-arybchenko@solarflare.com> <54455a54-fef1-8ad7-0bea-6c864bc4cbbe@solarflare.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Ferruh Yigit To: Andrew Rybchenko Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D9E602E81 for ; Wed, 30 May 2018 12:30:30 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 30/05/2018 11:42, Ferruh Yigit: > On 5/30/2018 7:44 AM, Andrew Rybchenko wrote: > > Thomas, Ferruh, > > > > I've found out that the following patch is deferred in patchwork: > > https://dpdk.org/dev/patchwork/patch/40455/ > > > > It is critical under certain conditions since fix application crash. > > The patch is net/sfc local and just few lines - absolutely harmless. > > The only potential DPDK-wide effect is build, but the patch is really > > trivial and it is hard to imagine how it could affect the build. > > I'd like it to be included in 18.05, if possible. > > > > I understand that 18.05 is really very-very late already and it > > could be too late even for such patch. Just would like to > > double-check it. > > Hi Andrew, > > I did mark it as deferred and I overlooked that this fixes a crash. > > Agree that scope is local and only effect should be build, I confirmed the build > but to be sure I suggest get the patch and trigger an Intel daily build, and > include the patch into release if only that build also returns success. > > > > > Thanks, > > Andrew. > > > > On 05/28/2018 09:50 AM, Andrew Rybchenko wrote: > >> Rx descriptor status callback was lost and request of the Rx > >> descriptor status crashes application if equal stride super-buffer > >> Rx mode is used. > >> > >> Fixes: 390f9b8d82c9 ("net/sfc: support equal stride super-buffer Rx mode") > >> > >> Signed-off-by: Andrew Rybchenko Applied, thanks for the heads up.