From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2] drivers: prefix driver REGISTER macro
	with RTE PMD
Date: Sun, 09 Oct 2016 21:50:56 +0200
Message-ID: <4525292.xovB97rfbE@xps13>
References: <1475949668-26829-1-git-send-email-shreyansh.jain@nxp.com>
 <184506162.Hjg7Xy8FWv@xps13>
 <DB5PR0401MB205405EE94FDB4A25437138290D80@DB5PR0401MB2054.eurprd04.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "david.marchand@6wind.com" <david.marchand@6wind.com>, dev@dpdk.org,
 "nhorman@tuxdriver.com" <nhorman@tuxdriver.com>
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f50.google.com (mail-lf0-f50.google.com
 [209.85.215.50]) by dpdk.org (Postfix) with ESMTP id BA5465398
 for <dev@dpdk.org>; Sun,  9 Oct 2016 21:50:58 +0200 (CEST)
Received: by mail-lf0-f50.google.com with SMTP id b81so88878917lfe.1
 for <dev@dpdk.org>; Sun, 09 Oct 2016 12:50:58 -0700 (PDT)
In-Reply-To: <DB5PR0401MB205405EE94FDB4A25437138290D80@DB5PR0401MB2054.eurprd04.prod.outlook.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-10-09 15:12, Shreyansh Jain:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > 2016-10-08 23:35, Shreyansh Jain:
> > > +PMDINFO_TO_O = if grep -E 'RTE_PMD_REGISTER_PCI\([0-9a-zA-Z,_\.
> > ]+\)|RTE_PMD_REGISTER_VDEV\([0-9a-zA-Z,_\. ]+\)' $<;\
> > > +       then \
> > 
> > I don't understand why you don't simply grep 'RTE_PMD_REGISTER_.*(' ?
> 
> Because I want to make sure that the grep matches only the DRIVER registration functions.
> In case a new macro (or driver type) is added in future, this macro can be updated. This way we can reduce the probability of a faulty match.
> 
> Is there a problem with closest possible match?

It is just long and useless. A macro starting with RTE_PMD_REGISTER_ must
be called from a PMD. What else?