From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 1/6] librte_log: add function to retrieve log_level Date: Fri, 13 Nov 2015 12:49:36 +0100 Message-ID: <4536748.1MnZAysZE1@xps13> References: <1447397258-27233-1-git-send-email-mhall@mhcomputing.net> <1447397258-27233-2-git-send-email-mhall@mhcomputing.net> <20151113114008.GA15612@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Bruce Richardson , Matthew Hall Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 7E7AD940C for ; Fri, 13 Nov 2015 12:50:49 +0100 (CET) Received: by wmvv187 with SMTP id v187so77522750wmv.1 for ; Fri, 13 Nov 2015 03:50:49 -0800 (PST) In-Reply-To: <20151113114008.GA15612@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-11-13 11:40, Bruce Richardson: > On Fri, Nov 13, 2015 at 06:47:33AM +0000, Matthew Hall wrote: > > --- a/lib/librte_eal/common/include/rte_log.h > > +++ b/lib/librte_eal/common/include/rte_log.h > > @@ -131,6 +131,7 @@ void rte_set_log_level(uint32_t level); > > > > /** > > * Get the global log level. > > + * > > */ > > uint32_t rte_get_log_level(void); > > > I don't think this patch is necessary, as all it adds is a single extra line to > a comment. I'm sad for you Bruce: you only see an empty line where you could catch the beauty of the star ;) Matthew, obviously you failed your send. As a general comment, please group patches by logic meaning and check them before sending ;)