From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v10 2/4] mk: Fix missing directory with
	combined extlib build
Date: Tue, 08 Dec 2015 01:49:47 +0100
Message-ID: <4540150.cJ2HfHJFer@xps13>
References: <1449496140-11758-1-git-send-email-remy.horton@intel.com>
 <1449496140-11758-3-git-send-email-remy.horton@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Remy Horton <remy.horton@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id F24702E81
 for <dev@dpdk.org>; Tue,  8 Dec 2015 01:50:59 +0100 (CET)
Received: by wmec201 with SMTP id c201so9687136wme.1
 for <dev@dpdk.org>; Mon, 07 Dec 2015 16:50:59 -0800 (PST)
In-Reply-To: <1449496140-11758-3-git-send-email-remy.horton@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-12-07 13:48, Remy Horton:
> Signed-off-by: Remy Horton <remy.horton@intel.com>
> ---
>  mk/rte.extlib.mk | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/mk/rte.extlib.mk b/mk/rte.extlib.mk
> index 4d459e4..47023a3 100644
> --- a/mk/rte.extlib.mk
> +++ b/mk/rte.extlib.mk
> @@ -42,11 +42,17 @@ export NOT_FIRST_CALL
>  
>  all:
>  	$(Q)mkdir -p $(RTE_OUTPUT)
> +ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),y)
> +	$(Q)mkdir -p $(RTE_OUTPUT)/build/lib
> +endif

This directory is created to copy an object file which is not never used.

I suggest this approach instead:

--- a/mk/rte.lib.mk
+++ b/mk/rte.lib.mk
@@ -136,7 +136,7 @@ endif
                $(depfile_newer)),\
                $(O_TO_S_DO))
 
-ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),y)
+ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS)$(EXTLIB_BUILD),yn)
        $(if $(or \
         $(file_missing),\
         $(call cmdline_changed,$(O_TO_C_STR)),\
@@ -159,7 +159,7 @@ $(LIB): $(OBJS-y) $(DEP_$(LIB)) FORCE
            $(depfile_missing),\
            $(depfile_newer)),\
            $(O_TO_A_DO))
-ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),y)
+ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS)$(EXTLIB_BUILD),yn)
        $(if $(or \
         $(file_missing),\
         $(call cmdline_changed,$(O_TO_C_STR)),\

The combine lib is not prepared for external lib objects.