From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4] pci_vfio: Support 64KB kernel page_size with vfio-pci driver Date: Thu, 20 Dec 2018 00:05:50 +0100 Message-ID: <45449763.apuXktMTFV@xps> References: <1542595044-27145-1-git-send-email-tone.zhang@arm.com> <1544613959-14349-1-git-send-email-tone.zhang@arm.com> <1c4528d9-7c19-c781-8d83-9e790dc81ffc@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Burakov, Anatoly" , gavin.hu@arm.com, honnappa.nagarahalli@arm.com, Steve.Capper@arm.com, stephen@networkplumber.org, nd@arm.com To: "tone.zhang" Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 2630D58F6 for ; Thu, 20 Dec 2018 00:05:54 +0100 (CET) In-Reply-To: <1c4528d9-7c19-c781-8d83-9e790dc81ffc@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/12/2018 12:27, Burakov, Anatoly: > On 12-Dec-18 11:25 AM, tone.zhang wrote: > > With a larger PAGE_SIZE it is possible for the MSI table to very > > close to the end of the BAR s.t. when we align the start and end > > of the MSI table to the PAGE_SIZE, the end offset of the MSI > > table is out of the PCI BAR boundary. > > > > This patch addresses the issue by comparing both the start and the > > end offset of the MSI table with the BAR size, and skip the mapping > > if it is out of Bar scope. > > > > The patch fixes the debug log as below: > > EAL: Skipping BAR0 > > > > Signed-off-by: tone.zhang > > Reviewed-by: Gavin Hu > > Reviewed-by: Honnappa Nagarahalli > > Reviewed-by: Steve Capper > > Reviewed-by: Anatoly Burakov > > --- > > Acked-by: Anatoly Burakov Applied, thanks