From mboxrd@z Thu Jan  1 00:00:00 1970
From: santosh <santosh.shukla@caviumnetworks.com>
Subject: Re: [PATCH v4 1/7] mempool: fix flags data type
Date: Mon, 4 Sep 2017 19:48:08 +0530
Message-ID: <4551380e-0b62-2ca6-4228-c02be8535748@caviumnetworks.com>
References: <20170720134759.4680-1-santosh.shukla@caviumnetworks.com>
 <20170815060743.21076-1-santosh.shukla@caviumnetworks.com>
 <20170815060743.21076-2-santosh.shukla@caviumnetworks.com>
 <20170904141154.vpj3hhmzp7pkjpg3@neon>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, thomas@monjalon.net, jerin.jacob@caviumnetworks.com,
 hemant.agrawal@nxp.com
To: Olivier MATZ <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam03on0074.outbound.protection.outlook.com [104.47.41.74])
 by dpdk.org (Postfix) with ESMTP id E83BB58F6
 for <dev@dpdk.org>; Mon,  4 Sep 2017 16:18:31 +0200 (CEST)
In-Reply-To: <20170904141154.vpj3hhmzp7pkjpg3@neon>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On Monday 04 September 2017 07:41 PM, Olivier MATZ wrote:
> On Tue, Aug 15, 2017 at 11:37:37AM +0530, Santosh Shukla wrote:
>> mp->flags is int and mempool API updates unsigned int
>> value in 'flags', so fix the 'flags' data type.
>>
>> Patch also does mp->flags cleanup like:
>> * Remove redundant 'flags' API description from
>>   - __rte_mempool_generic_put
>>   - __rte_mempool_generic_get
>>
>> * Remove unused 'flags' param from
>>   - rte_mempool_generic_put
>>   - rte_mempool_generic_get
>>
>> * Fix mempool var data types int mempool.c
>>   - mz_flags is int, Change it to unsigned int.
> This bullet list makes me think that we should have at least 2 commits:
>  mempool: remove unused flags argument
>  mempool: change flags from int to unsigned int
>
Ok, will split in v5.