From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] eal: fix build
Date: Wed, 29 Jul 2015 17:08:42 +0200
Message-ID: <4566288.d5QVtI4JvI@xps13>
References: <1438123707-26509-1-git-send-email-helin.zhang@intel.com>
 <4457109.BKbKVosbHQ@xps13>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70A8B6FE3@SHSMSX104.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: "Zhang, Helin" <helin.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com
 [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 5DB86C438
 for <dev@dpdk.org>; Wed, 29 Jul 2015 17:09:57 +0200 (CEST)
Received: by wibud3 with SMTP id ud3so224941975wib.1
 for <dev@dpdk.org>; Wed, 29 Jul 2015 08:09:57 -0700 (PDT)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A8B6FE3@SHSMSX104.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-07-29 15:00, Zhang, Helin:
> Hi Thomas
>=20
> It was just an implicit declaration of function, when set
> CONFIG_RTE_PCI_CONFIG=3Dy, as follows. Nobody else cares about it.

Why do we have this config option?
Please remove these useless ifdef's.

> /home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/common/eal_common_p=
ci.c: In function =C3=A2=E2=82=AC?rte_eal_pci_probe_one_driver=C3=A2=E2=
=82=AC=E2=84=A2:
> /home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/common/eal_common_p=
ci.c:188:4: error: implicit declaration of function =C3=A2=E2=82=AC?pci=
_config_space_set=C3=A2=E2=82=AC=E2=84=A2 [-Werror=3Dimplicit-function-=
declaration]
>     pci_config_space_set(dev);
>     ^
> /home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/common/eal_common_p=
ci.c:188:4: error: nested extern declaration of =C3=A2=E2=82=AC?pci_con=
fig_space_set=C3=A2=E2=82=AC=E2=84=A2 [-Werror=3Dnested-externs]
> cc1: all warnings being treated as errors
> /home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/linuxapp/eal/eal_pc=
i.c:561:1: error: =C3=A2=E2=82=AC?pci_config_space_set=C3=A2=E2=82=AC=E2=
=84=A2 defined but not used [-Werror=3Dunused-function]
>  pci_config_space_set(struct rte_pci_device *dev)
>  ^
> cc1: all warnings being treated as errors

So I will change the title to:
=09eal: fix build with pci config enabled

and add this into the message:
=09Build log:
=09=09lib/librte_eal/common/eal_common_pci.c:188:4: error:
=09=09implicit declaration of function pci_config_space_set


> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > Sent: Wednesday, July 29, 2015 1:20 AM
> > To: Zhang, Helin
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] eal: fix build
> >=20
> > 2015-07-29 06:48, Helin Zhang:
> > > It fixes the build error of implicit declaration of function.
> >=20
> > What is the error?
> > Please show the build log and describe the case when it happens (co=
mpiler,
> > version).