From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2826CC7618E for ; Tue, 23 Jul 2019 12:51:05 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id AAF5C21901 for ; Tue, 23 Jul 2019 12:51:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="ptDVRmdj"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="puWn5b7Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AAF5C21901 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 864B71C020; Tue, 23 Jul 2019 14:51:01 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id C34231C012; Tue, 23 Jul 2019 14:50:58 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 892E04F2; Tue, 23 Jul 2019 08:50:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 23 Jul 2019 08:50:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=FBuDvM1Hz+B0PRRqnD3hV6aU5zJIJeIeIn8621WmMVk=; b=ptDVRmdjevVx xXcaI6ps7uF/2/P/svna+7qp+rGDLuFZa0D0965jIqlckiORurPQUftFDqhRr+0i DCkZl94ybwR0cPRFKddkFuWwnqXf8C63pL4lnKbeNwO56JNXHqB1J/qSIhXCLtkb 38gTUuqKuC1zagpCtV4aSNqvd5iVlIU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=FBuDvM1Hz+B0PRRqnD3hV6aU5zJIJeIeIn8621WmM Vk=; b=puWn5b7QWPSseO9PGXhlI65DKQ+qdeErJZ8tZgkHji9N5Q/6w+Xqs6wzI loVyJMa3z34F3GJ2k5dy94My/G6RZVHyzt76e/1pW2X+lhLEkes44rwecdGw9W8z HgdpGz/A1qMWDVNmr18c4cI8W2jKW56mVvYyGBvoAeWhXy3pMZDTbuxuzCT1ej5Z JFOH7omwunmrCoiEOUz5Iv/Gmkg5944Y5JFU5uljne7Z3X9IvJeJCrPZgk/3+I50 u/++Fh7b70tQO59odF5rBTzJov5f3agPZY0gzvCAauHAD7kFZphcTkqNZPsOVjDC zr+w8rqg6Rz/QhuHYxSEw7bkmjzsg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrjeekgdehkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3F45A380075; Tue, 23 Jul 2019 08:50:56 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko Cc: Ferruh Yigit , dev@dpdk.org, stable@dpdk.org Date: Tue, 23 Jul 2019 14:50:52 +0200 Message-ID: <4582049.OHkX9IKj5f@xps> In-Reply-To: <580e3eb6-6011-307c-5480-ffd9c7539b53@solarflare.com> References: <1563873208-5096-1-git-send-email-arybchenko@solarflare.com> <09016541-b6d3-61b0-bfbe-8af4394a3b45@intel.com> <580e3eb6-6011-307c-5480-ffd9c7539b53@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: avoid usage of uninit device info in bad port case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/07/2019 14:16, Andrew Rybchenko: > On 7/23/19 1:40 PM, Ferruh Yigit wrote: > > On 7/23/2019 10:13 AM, Andrew Rybchenko wrote: > >> rte_eth_dev_info_get() returns void and caller does know if the function > >> does its job or not. Changing of the return value to int would be > >> API/ABI breakage which requires deprecation process and cannot be > >> backported to stable branches. For now, make sure that device info is > >> initialized even in the case of invalid port ID. > > +1 to return a status from function for long term. > > Thomas, what do you think? Should we finally fix it? > I think it is almost harmless API/ABI breakage. > If yes, I'll send deprecation notice to do it in v19.11. Yes, generally speaking we should not have any void return in API.