From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2] malloc: fix combined lib build
Date: Wed, 22 Jul 2015 10:26:58 +0200
Message-ID: <4582360.pG3T7yarLt@xps13>
References: <1437473890-17279-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <1437474797-19778-1-git-send-email-sergio.gonzalez.monroy@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com
 [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id B8C143772
 for <dev@dpdk.org>; Wed, 22 Jul 2015 10:28:10 +0200 (CEST)
Received: by wicmv11 with SMTP id mv11so70852244wic.0
 for <dev@dpdk.org>; Wed, 22 Jul 2015 01:28:10 -0700 (PDT)
In-Reply-To: <1437474797-19778-1-git-send-email-sergio.gonzalez.monroy@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> Malloc was moved to the EAL and dummy malloc library was left
> to not break apps that had a librte_malloc.so dependency.
> Note that the dummy library will be removed in the next release.
> 
> When building a combined library, all objects are copied to the same
> directory before creating the library itself.
> 
> There are a few issues:
>  - CONFIG_RTE_LIBRTE_MALLOC is not a valid option anymore resulting
>  in wrong syntax and a compilation failure. Fix it by replacing it
>  with CONFIG_RTE_LIBRTE_EAL.
>  - As we kept a dummy library, there are now two objects with the
>  same name. This means that the proper rte_malloc.o object in eal gets
>  overwritten by an empty rte_malloc.o object from the dummy malloc lib.
>  Fix it by changing the name of rte_malloc.o object in the dummy
>  library.
>  - Update the copyright year.
> 
> Fixes: 2f9d47013e4dbb738 ("mem: move librte_malloc to eal/common")
> 
> Reported-by: Alin Rauta <alin.rauta@intel.com>
> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>

Applied, thanks