From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 00/19] A new net PMD - ice Date: Wed, 05 Dec 2018 08:28:34 +0100 Message-ID: <4582980.XP1efssEEA@xps> References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com> <2482097.kNToWcbbbU@xps> <6A0DE07E22DDAD4C9103DF62FEBC09093FE11281@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Lu, Wenzhuo" Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id B76891B150 for ; Wed, 5 Dec 2018 08:28:37 +0100 (CET) In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093FE11281@shsmsx102.ccr.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/12/2018 07:39, Lu, Wenzhuo: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 23/11/2018 07:56, Wenzhuo Lu: > > > net/ice: add base code > > > > This first patch is really too big. > > Please could you try to split it logically? > > This is base code which is not developed by us. We're not so familiar with it. It's the first time to release the code, I know it's too big, to us too. But anyway we'll maintain it. > To save the effort, we always don't split the base code when releasing it at the first time. Is that OK? It's not the best start. How a very new driver can start with so many code and not being fully understood by those who will maintain it? It's really better to start small and grow. It would ease both testing and understanding.