From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] test: fix the parameter issue of test case
Date: Fri, 21 Jul 2017 09:42:26 +0300
Message-ID: <4587531.0fQc3qA4qG@xps>
References: <1499932836-25309-1-git-send-email-herbert.guan@arm.com>
 <CAP4Qi3-mOZVNXKErQQKhL0ra+aZS0sYAp77to5HHe2csHY_41A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Jianbo Liu <jianbo.liu@linaro.org>,
 Herbert Guan <herbert.guan@arm.com>
To: Declan Doherty <declan.doherty@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 17AC429C8
 for <dev@dpdk.org>; Fri, 21 Jul 2017 08:42:30 +0200 (CEST)
In-Reply-To: <CAP4Qi3-mOZVNXKErQQKhL0ra+aZS0sYAp77to5HHe2csHY_41A@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Declan, you are the bonding maintainer, please confirm this fix.

13/07/2017 11:48, Jianbo Liu:
> On 13 July 2017 at 16:00, Herbert Guan <herbert.guan@arm.com> wrote:
> > When test case "test_balance_l23_tx_burst_ipv4_toggle_ip_addr" is
> > calling balance_l23_tx_burst(), the ip_addr instead of mac_addr
> > should be toggled according to the test name.
> >
> > Signed-off-by: Herbert Guan <herbert.guan@arm.com>
> > ---
> >  test/test/test_link_bonding.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/test/test/test_link_bonding.c b/test/test/test_link_bonding.c
> > index aa2a1a2..12dd91d 100644
> > --- a/test/test/test_link_bonding.c
> > +++ b/test/test/test_link_bonding.c
> > @@ -2789,7 +2789,7 @@ struct rte_fdir_conf fdir_conf = {
> >  static int
> >  test_balance_l23_tx_burst_ipv4_toggle_ip_addr(void)
> >  {
> > -       return balance_l23_tx_burst(0, 1, 1, 0);
> > +       return balance_l23_tx_burst(0, 1, 0, 1);
> >  }
> >
> >  static int
> > --
> > 1.8.3.1
> >
> 
> Acked-by: Jianbo Liu <jianbo.liu@linaro.org>
>