From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] bus/dpaa/base: fix build when assert enabled Date: Sat, 23 Dec 2017 16:23:28 +0100 Message-ID: <4608926.QE3OKlIoMx@xps> References: <20171222021316.52433-1-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Shreyansh Jain , Hemant Agrawal , stable@dpdk.org To: Ferruh Yigit Return-path: In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/12/2017 08:05, Shreyansh Jain: > On Friday 22 December 2017 07:43 AM, Ferruh Yigit wrote: > > Enabling CONFIG_RTE_ENABLE_ASSERT cause build error because some fields > > protected by RTE_LIBRTE_DPAA_HWDEBUG macro accessed within DPAA_ASSERT. > > > > All DPAA_ASSERT macro usage causing the build error wrapped with > > RTE_LIBRTE_DPAA_HWDEBUG macro. > > > > Fixes: f38f61e982f8 ("bus/dpaa: add BMAN hardware interfaces") > > Fixes: c47ff048b99a ("bus/dpaa: add QMAN driver core routines") > > Cc: shreyansh.jain@nxp.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Ferruh Yigit > > In near future, I will find a better way to have HWDEBUG. But, until > that time, we can go with this patch. > Ferruh, thanks for doing this. > > Acked-by: Shreyansh Jain Applied, thanks