From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 2/2] igb: release software locked semaphores on initialization Date: Wed, 09 Apr 2014 18:39:56 +0200 Message-ID: <4611478.9TdyNLhD18@xps13> References: <530DC788.8020706@6wind.com> <1396963798-13123-2-git-send-email-didier.pallard@6wind.com> <2601191342CEEE43887BDE71AB9772580EF95738@IRSMSX105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Ananyev, Konstantin" , Didier Pallard Return-path: In-Reply-To: <2601191342CEEE43887BDE71AB9772580EF95738-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > It may happen that DPDK application gets killed while having acquired locks > on the ethernet hardware, causing these locks to be never released. On next > restart of the application, DPDK skip those ports because it can not > acquire the lock, this may cause some ports (or even complete board if SMBI > is locked) to be inaccessible from DPDK application until reboot of the > hardware. > > This patch release locks that are supposed to be locked due to an improper > exit of the application. > > Signed-off-by: Didier Pallard > Acked-by: Konstantin Ananyev Applied for version 1.6.0r2. So the decision is to try not modify base driver. But the fix should appear in the base driver one day and we must be careful when rebasing on an updated one. In this case, the fix can be done on both side without being harmful. Thanks for fixing this random failure. -- Thomas