From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v6 06/10] mk: Add rule for installing sdk files Date: Mon, 30 Nov 2015 17:20:31 +0100 Message-ID: <4614982.E3BTLgVdAm@xps13> References: <1442608390-12537-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <1447175260-26162-1-git-send-email-mario.alfredo.c.arevalo@intel.com> <1447175260-26162-7-git-send-email-mario.alfredo.c.arevalo@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, jos.c.venegas.munoz@intel.com To: Mario Carrillo Return-path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 270CD69C8 for ; Mon, 30 Nov 2015 17:21:40 +0100 (CET) Received: by wmec201 with SMTP id c201so145761154wme.1 for ; Mon, 30 Nov 2015 08:21:40 -0800 (PST) In-Reply-To: <1447175260-26162-7-git-send-email-mario.alfredo.c.arevalo@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, 2015-11-10 11:07, Mario Carrillo: > Add hierarchy-file support to the DPDK makefiles, scripts, > examples, tools, config files and headers, > when invoking "make install-sdk" makefiles, scripts, > examples, tools, config files will be installed in: The tools are part of the runtime, not the sdk. > $(DESTDIR)/$(SDK_DIR) > and headers will be installed in: > $(DESTDIR)/$(INCLUDE_DIR) > where SDK_DIR=$(RTE_PREFIX)/share/dpdk, > INCLUDE_DIR=$(RTE_PREFIX)/include/dpdk > RTE_PREFIX=/usr/local by default, you can override RTE_PREFIX, SDK_DIR > and INCLUDE_DIR vars. > This hierarchy is based on: > http://www.freedesktop.org/software/systemd/man/file-hierarchy.html It would be better to follow the GNU standard to name the variables: https://www.gnu.org/prep/standards/html_node/Directory-Variables.html https://www.gnu.org/prep/standards/html_node/DESTDIR.html prefix ?= /usr/local exec_prefix ?= $(prefix) bindir ?= $(exec_prefix)/bin sbindir ?= $(exec_prefix)/sbin libdir ?= $(exec_prefix)/lib includedir ?= $(prefix)/include/dpdk datarootdir ?= $(prefix)/share docdir ?= $(datarootdir)/doc/dpdk datadir ?= $(datarootdir)/dpdk I would add: kerneldir ?= $(exec_prefix)/kmod sdkdir ?= $(datadir)