From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ethdev: fix link status query Date: Tue, 10 Apr 2018 10:29:18 +0200 Message-ID: <4616956.1DYh5m3MiB@xps> References: <20180410061631.50301-1-shahafs@mellanox.com> <20180410082051.vhumihdzc3qhy7wy@laranjeiro-vm.dev.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: =?ISO-8859-1?Q?N=E9lio?= Laranjeiro , ferruh.yigit@intel.com, dev@dpdk.org, stable@dpdk.org, stephen@networkplumber.org To: Shahaf Shuler Return-path: In-Reply-To: <20180410082051.vhumihdzc3qhy7wy@laranjeiro-vm.dev.6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/04/2018 10:20, N=E9lio Laranjeiro: > On Tue, Apr 10, 2018 at 09:16:31AM +0300, Shahaf Shuler wrote: > > When application works with LSC interrupts the ethdev layer skips > > the PMD callback and update according to the link status exists on > > device data. It is because it assumes the link status on the device data > > is the correct one since any link change is processed by the applicatio= n. > >=20 > > As multiple PMDs install the link status interrupt handler only on port > > start and uninstall it on port stop, the link status may be incorrect in > > case the query is called after port stop or before port start. >=20 > It seems also logical to not process interrupts from stopped device, > for them accessing to the link status should always end by calling the > devop function. >=20 > This patch is the result of discussion on thread [1]. >=20 > > Fixing the query implementation to use the PMD callback for such cases. > >=20 > > Fixes: b77d21cc2364 ("ethdev: add link status get/set helper functions") > > Cc: stable@dpdk.org > > Cc: stephen@networkplumber.org > > Cc: nelio.laranjeiro@6wind.com >=20 > Acked-by: Nelio Laranjeiro >=20 > > Signed-off-by: Shahaf Shuler Looks OK Acked-by: Thomas Monjalon