From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] vhost: Fix the vhost broken issue Date: Fri, 17 Oct 2014 09:28:27 +0200 Message-ID: <4665765.pNYqlQvYlS@xps13> References: <1413185980-17348-1-git-send-email-changchun.ouyang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Xie, Huawei" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-10-17 03:19, Xie, Huawei: > From: Ouyang, Changchun > > From: Xie, Huawei > > > I generated the vhost example patch based on vhost library, but find > > > there is > > > issue with --mergeable feature. > > > Only thousands of packets could be sent. > > > Then I tried the latest vhost example, which is just before my vhost > > > lib patch, I found that not only it has the issue Which is fixed by the > > > following patch but the --mergeable feature also doesn't work. > > > Haven't got the change to dig into it. > > > > > > Hints here: > > > 1. mbuf allocation failure after thousands of packets. > > > 2. disable INC_VEC(vectore scatter receive) in configure could solve > > > this. > > > 3. tried sending the packets directly out after receiving from vmdq > > > queue, it > > > works. > > > > > > Could you root cause the issue, Changchun? You could work on the most > > > recent > > > example. > > > > No problem, I will investigate the root cause. > > > > But before figuring out the root cause, I think we could add check in your new > > sample to > > Check the INC_VEC is enable or not, If it is enabled, print error message and hint > > user > > Disable it in config file if mergeable feature is triggered in vhost. Then this issue > > should not > > block you from sending out your vhost app patch. > > > > Your vhost app patch will block my another patch about multicast feature as > > your vhost lib patch delete the vhost sample app totally. > > So expect your vhost app patch send out soon. > > Thomas: > Thoughts about this? Could I send example patch with this walk around? Yes, please send the new example with this small workaround. It's better than nothing. -- Thomas