From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 1/7] pci: If a driver's probe function fails, unmap resources. Date: Mon, 09 Jan 2017 18:12:07 +0100 Message-ID: <4689267.aT7BcNq7bb@xps13> References: <1479929804-19614-1-git-send-email-benjamin.walker@intel.com> <2631459.aun9V5NdHs@xps13> <64510177.2V8Gqa4j9X@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Shreyansh Jain , dev@dpdk.org To: Ben Walker Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 276B62C58 for ; Mon, 9 Jan 2017 18:12:09 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id a197so104601331wmd.0 for ; Mon, 09 Jan 2017 09:12:09 -0800 (PST) In-Reply-To: <64510177.2V8Gqa4j9X@xps13> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-01-04 18:39, Thomas Monjalon: > 2016-12-21 17:19, Thomas Monjalon: > > 2016-11-25 14:51, Shreyansh Jain: > > > On Thursday 24 November 2016 01:37 AM, Ben Walker wrote: > > > > If resources were mapped prior to probe, unmap them > > > > if probe fails. > > > > > > > > This does not handle the case where the kernel driver was > > > > forcibly unbound prior to probe. > > > > > > > > Signed-off-by: Ben Walker > > > > > > Acked-by: Shreyansh Jain > > > > The 3 first patches of this series seems good and easy to agree, > > except some minor nits. > > > > Please Ben or Shreyansh, could you respin only them to help make > > progress before applying a PCI/bus rework from Shreyansh? > > As soon as one of you shoot a partial v3, I'll apply them. > > Thanks > > Please Ben, do you want to make a partial v3? Please, would you mind to re-send the first 3 patches as v3?