From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH v2 4/4] power: add UTs for all power env types
Date: Tue, 19 Mar 2019 11:58:48 +0000
Message-ID: <4716aa77-e4d2-6991-0482-8aa6ff34f57e@intel.com>
References: <20190318115647.14784-1-marcinx.hajkowski@intel.com>
 <20190318115647.14784-4-marcinx.hajkowski@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Hajkowski <marcinx.hajkowski@intel.com>, david.hunt@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id C7FABA3
 for <dev@dpdk.org>; Tue, 19 Mar 2019 12:58:51 +0100 (CET)
In-Reply-To: <20190318115647.14784-4-marcinx.hajkowski@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 18-Mar-19 11:56 AM, Hajkowski wrote:
> From: Marcin Hajkowski <marcinx.hajkowski@intel.com>
> 
> Test all existing power environment configuration to verify if related
> data is properly initialized and clean in set/unset scenarios.
> 
> Signed-off-by: Marcin Hajkowski <marcinx.hajkowski@intel.com>
> ---

<snip>

> +
>   	rte_power_unset_env();
> +
> +	/* Perform tests for valid environments.*/
> +	const enum power_management_env envs[] = {PM_ENV_ACPI_CPUFREQ,
> +						PM_ENV_KVM_VM,
> +						PM_ENV_PSTATE_CPUFREQ};

Extreme nitpicking, but i believe we use two indentation levels for 
continuation.

Otherwise

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly