From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] ixgbe: fix icc issue with mbuf initializer Date: Wed, 05 Nov 2014 22:45:52 +0100 Message-ID: <4733896.5T345UQtsj@xps13> References: <1415013076-30314-1-git-send-email-bruce.richardson@intel.com> <1415034068-22656-1-git-send-email-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Bruce Richardson Return-path: In-Reply-To: <1415034068-22656-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > When using Intel C++ compiler(icc) 14.0.1.106 or the older icc 13.x > version, the mbuf initializer variable was not getting configured > correctly, as the mb_def variable was not set correctly. This is due > to an issue with icc (DPD200249565 which already been fixed in > icc 14.0.2 and newer compiler release) where it incorrectly calculates > the field offsets with initializers when zero-sized fields > are used in a structure. > To work around this, the code in ixgbe_rxq_vec_setup does not setup the > fields using an initializer, but instead assigns the values individually > in code > NOTE: There is no performance impact to this change as the queue > setup functions are not data-plane APIs, but are only used at app > initialization. > > Signed-off-by: Bruce Richardson Acked-by: Thomas Monjalon Applied Thanks -- Thomas