From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ethdev: don't count missed packets in erroneous packets counter Date: Tue, 22 Mar 2016 11:06:05 +0100 Message-ID: <4735724.6EMEy1TxCb@xps13> References: <1457615010-87436-1-git-send-email-iryzhov@nfware.com> <2180400.M1OUCR6DC3@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, maryam.tahhan@intel.com, olivier.matz@6wind.com To: Igor Ryzhov Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 816CF374F for ; Tue, 22 Mar 2016 11:07:45 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id r129so84947434wmr.1 for ; Tue, 22 Mar 2016 03:07:45 -0700 (PDT) In-Reply-To: <2180400.M1OUCR6DC3@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-17 17:40, Thomas Monjalon: > CC Maryam and Olivier who had discussions about imissed and other stats: > http://dpdk.org/ml/archives/dev/2015-August/022905.html > http://dpdk.org/ml/archives/dev/2015-September/023351.html > http://dpdk.org/ml/archives/dev/2015-September/023612.html > > 2016-03-10 16:03, Igor Ryzhov: > > Comment for "ierrors" counter says that it counts erroneous received packets. But for some reason "imissed" counter is added to "ierrors" counter in most drivers. It is a mistake, because missed packets are obviously not received. This patch fixes it. > > According to this patch > http://dpdk.org/browse/dpdk/commit/?id=70bdb186 > imissed was kept in ierrors because of backward compatibility. > I'm OK to remove imissed from ierrors. > > Fixes: 70bdb18657da ("ethdev: add Rx error counters for missed, badcrc and badlen packets") > Fixes: 6bfe648406b5 ("i40e: add Rx error statistics") > Fixes: 856505d303f4 ("cxgbe: add port statistics") > > Acked-by: Thomas Monjalon Applied, thanks