From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 2/3] net/cxgbe: remove unused variable usage
Date: Wed, 25 Jan 2017 12:13:57 +0000
Message-ID: <4742eebd-1712-db20-26b0-d2a8e1f9aaf8@intel.com>
References: <20170124204859.8998-1-emmanuel.roullit@gmail.com>
 <20170124204859.8998-2-emmanuel.roullit@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Emmanuel Roullit <emmanuel.roullit@gmail.com>, rahul.lakkireddy@chelsio.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 1AB9B2BA3
 for <dev@dpdk.org>; Wed, 25 Jan 2017 13:13:59 +0100 (CET)
In-Reply-To: <20170124204859.8998-2-emmanuel.roullit@gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/24/2017 8:48 PM, Emmanuel Roullit wrote:
> Found with clang static analysis:
> drivers/net/cxgbe/sge.c:900:3: warning:
> Value stored to 'in_use' is never read
>         in_use += q->size;
>         ^         ~~~~~~~
> 
> Fixes: c167acb61278 ("net/cxgbe: use I/O device memory read/write API")
> 
> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
> ---
>  drivers/net/cxgbe/sge.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c
> index fc03a0c26..42051ca01 100644
> --- a/drivers/net/cxgbe/sge.c
> +++ b/drivers/net/cxgbe/sge.c
> @@ -891,14 +891,10 @@ static inline int should_tx_packet_coalesce(struct sge_eth_txq *txq,
>  	unsigned int flits, ndesc;
>  	unsigned char type = 0;
>  	int credits, hw_cidx = ntohs(q->stat->cidx);
> -	int in_use = q->pidx - hw_cidx + flits_to_desc(q->coalesce.flits);
>  
>  	/* use coal WR type 1 when no frags are present */
>  	type = (mbuf->nb_segs == 1) ? 1 : 0;
>  
> -	if (in_use < 0)
> -		in_use += q->size;

Intention can be "q->in_use" here. That change can be proper fix instead
of removing.

I will wait for maintainers comment to get the patch.

> -
>  	if (unlikely(type != q->coalesce.type && q->coalesce.idx))
>  		ship_tx_pkt_coalesce_wr(adap, txq);
>  
>