* [PATCH] ixgbe: fix the issue second 5tuple filter overwrites the first one
@ 2015-03-25 4:47 Jingjing Wu
[not found] ` <1427258833-5070-1-git-send-email-jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Jingjing Wu @ 2015-03-25 4:47 UTC (permalink / raw)
To: dev-VfR2kkLFssw
This patch corrects the index to fix the issue that is second 5tuple filter
overwrites the first one.
Signed-off-by: Jingjing Wu <jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
index 92d75db..5caee22 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
@@ -3882,10 +3882,10 @@ ixgbe_add_5tuple_filter(struct rte_eth_dev *dev,
ftqf |= IXGBE_FTQF_POOL_MASK_EN;
ftqf |= IXGBE_FTQF_QUEUE_ENABLE;
- IXGBE_WRITE_REG(hw, IXGBE_DAQF(idx), filter->filter_info.dst_ip);
- IXGBE_WRITE_REG(hw, IXGBE_SAQF(idx), filter->filter_info.src_ip);
- IXGBE_WRITE_REG(hw, IXGBE_SDPQF(idx), sdpqf);
- IXGBE_WRITE_REG(hw, IXGBE_FTQF(idx), ftqf);
+ IXGBE_WRITE_REG(hw, IXGBE_DAQF(i), filter->filter_info.dst_ip);
+ IXGBE_WRITE_REG(hw, IXGBE_SAQF(i), filter->filter_info.src_ip);
+ IXGBE_WRITE_REG(hw, IXGBE_SDPQF(i), sdpqf);
+ IXGBE_WRITE_REG(hw, IXGBE_FTQF(i), ftqf);
l34timir |= IXGBE_L34T_IMIR_RESERVE;
l34timir |= (uint32_t)(filter->queue <<
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1427258833-5070-1-git-send-email-jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] ixgbe: fix the issue second 5tuple filter overwrites the first one [not found] ` <1427258833-5070-1-git-send-email-jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> @ 2015-03-25 4:56 ` Liu, Yong [not found] ` <86228AFD5BCD8E4EBFD2B90117B5E81E10DA9C09-0J0gbvR4kTggGBtAFL8yw7fspsVTdybXVpNB7YpNyf8@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Liu, Yong @ 2015-03-25 4:56 UTC (permalink / raw) To: Wu, Jingjing, dev-VfR2kkLFssw@public.gmane.org > -----Original Message----- > From: Wu, Jingjing > Sent: Wednesday, March 25, 2015 12:47 PM > To: dev-VfR2kkLFssw@public.gmane.org > Cc: Wu, Jingjing; Liu, Yong > Subject: [PATCH] ixgbe: fix the issue second 5tuple filter overwrites the > first one > > This patch corrects the index to fix the issue that is second 5tuple > filter > overwrites the first one. > > Signed-off-by: Jingjing Wu <jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Acked-by: Marvin Liu <yong.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > --- > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > index 92d75db..5caee22 100644 > --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c > @@ -3882,10 +3882,10 @@ ixgbe_add_5tuple_filter(struct rte_eth_dev *dev, > ftqf |= IXGBE_FTQF_POOL_MASK_EN; > ftqf |= IXGBE_FTQF_QUEUE_ENABLE; > > - IXGBE_WRITE_REG(hw, IXGBE_DAQF(idx), filter->filter_info.dst_ip); > - IXGBE_WRITE_REG(hw, IXGBE_SAQF(idx), filter->filter_info.src_ip); > - IXGBE_WRITE_REG(hw, IXGBE_SDPQF(idx), sdpqf); > - IXGBE_WRITE_REG(hw, IXGBE_FTQF(idx), ftqf); > + IXGBE_WRITE_REG(hw, IXGBE_DAQF(i), filter->filter_info.dst_ip); > + IXGBE_WRITE_REG(hw, IXGBE_SAQF(i), filter->filter_info.src_ip); > + IXGBE_WRITE_REG(hw, IXGBE_SDPQF(i), sdpqf); > + IXGBE_WRITE_REG(hw, IXGBE_FTQF(i), ftqf); > > l34timir |= IXGBE_L34T_IMIR_RESERVE; > l34timir |= (uint32_t)(filter->queue << > -- > 1.9.3 Acked-by: Marvin Liu <yong.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <86228AFD5BCD8E4EBFD2B90117B5E81E10DA9C09-0J0gbvR4kTggGBtAFL8yw7fspsVTdybXVpNB7YpNyf8@public.gmane.org>]
* Re: [PATCH] ixgbe: fix the issue second 5tuple filter overwrites the first one [not found] ` <86228AFD5BCD8E4EBFD2B90117B5E81E10DA9C09-0J0gbvR4kTggGBtAFL8yw7fspsVTdybXVpNB7YpNyf8@public.gmane.org> @ 2015-03-27 10:33 ` Thomas Monjalon 0 siblings, 0 replies; 3+ messages in thread From: Thomas Monjalon @ 2015-03-27 10:33 UTC (permalink / raw) To: Wu, Jingjing; +Cc: dev-VfR2kkLFssw > > This patch corrects the index to fix the issue that is second 5tuple > > filter > > overwrites the first one. > > > > Signed-off-by: Jingjing Wu <jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > > Acked-by: Marvin Liu <yong.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Fixes: 4c54a7e7bd42 ("ixgbe: migrate ntuple filter to new API") Applied, thanks ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-27 10:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-25 4:47 [PATCH] ixgbe: fix the issue second 5tuple filter overwrites the first one Jingjing Wu
[not found] ` <1427258833-5070-1-git-send-email-jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-03-25 4:56 ` Liu, Yong
[not found] ` <86228AFD5BCD8E4EBFD2B90117B5E81E10DA9C09-0J0gbvR4kTggGBtAFL8yw7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-03-27 10:33 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).