From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v6 02/14] net/avf: initialization of avf PMD
Date: Thu, 11 Jan 2018 08:53:51 +0000
Message-ID: <474da82a-0924-4cd2-c882-2f7c2cd39112@intel.com>
References: <1515388414-16214-1-git-send-email-wenzhuo.lu@intel.com>
 <1515564961-79227-1-git-send-email-wenzhuo.lu@intel.com>
 <1515564961-79227-3-git-send-email-wenzhuo.lu@intel.com>
 <20180110091525.7f6abb3b@xeon-e3>
 <6A0DE07E22DDAD4C9103DF62FEBC09093B70E202@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
 Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id AA91E1B16B
 for <dev@dpdk.org>; Thu, 11 Jan 2018 09:53:57 +0100 (CET)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B70E202@shsmsx102.ccr.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/11/2018 2:07 AM, Lu, Wenzhuo wrote:
> Hi Stephen,
> 
>> -----Original Message-----
>> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
>> Sent: Thursday, January 11, 2018 1:15 AM
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
>> Cc: dev@dpdk.org; Wu, Jingjing <jingjing.wu@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD
>>
>> On Wed, 10 Jan 2018 14:15:49 +0800
>> Wenzhuo Lu <wenzhuo.lu@intel.com> wrote:
>>
>>> +
>>> +#define AVF_MAX_NUM_QUEUES       16
>>> +/* Vlan table size */
>>> +#define AVF_VLAN_TB_SIZE               (4096 / (CHAR_BIT * sizeof(uint32_t)))
>>
>> You could use ETHER_MAX_VLAN_ID (which is 4095).
>> Also it is most efficient if bit tables use unsigned long to access.
> Thanks for the suggestion.
> I found this macro is useless. I'd like just removing it.
> 
> Hi Ferruh,
> As this patch set is accepted to next-net, I can sent a fixes patch for this change. Is it OK? Would you like helping merge the fixes to the original patch? Thanks.

Hi Wenzhuo,

That is OK, I can squash fixes on top original set in next-net.