From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 2/2] scripts: add build tests Date: Tue, 24 Nov 2015 19:14:52 +0100 Message-ID: <4758699.k09jfibQCa@xps13> References: <1445615606-3885-1-git-send-email-thomas.monjalon@6wind.com> <1448242808-16101-3-git-send-email-thomas.monjalon@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Mcnamara, John" Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 707EEB62 for ; Tue, 24 Nov 2015 19:16:14 +0100 (CET) Received: by wmww144 with SMTP id w144so150187910wmw.1 for ; Tue, 24 Nov 2015 10:16:10 -0800 (PST) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-11-24 17:49, Mcnamara, John: > Very useful. We should add these scripts to the contributing guide at some point. Yes > One minor nit. "q" is used for "quick" in this script and "quiet" in the checkpatch script. Maybe for consistency use "f" for fast or "n" for no-doc or something else. Consistency of short options is a difficult job. -f may work but can also be used to "force" in another script. I'll change it to -s (short) if there is no other comment.