From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v6 06/13] virtio: read virtio_net_config
	correctly
Date: Tue, 20 Oct 2015 09:27:37 +0200
Message-ID: <4759700.UeY5nRH9Wr@xps13>
References: <1444369572-1157-1-git-send-email-yuanhan.liu@linux.intel.com>
 <2143283.gKIdjTGCRD@xps13> <20151020072327.GV3115@yliu-dev.sh.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, marcel@redhat.com, "Michael S. Tsirkin" <mst@redhat.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com
 [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id 82ECD91A0
 for <dev@dpdk.org>; Tue, 20 Oct 2015 09:53:17 +0200 (CEST)
Received: by wicll6 with SMTP id ll6so15289554wic.1
 for <dev@dpdk.org>; Tue, 20 Oct 2015 00:53:16 -0700 (PDT)
In-Reply-To: <20151020072327.GV3115@yliu-dev.sh.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-10-20 15:23, Yuanhan Liu:
> On Tue, Oct 20, 2015 at 09:07:49AM +0200, Thomas Monjalon wrote:
> > 2015-10-09 13:46, Yuanhan Liu:
> > > From: Changchun Ouyang <changchun.ouyang@intel.com>
> > > 
> > > The old code adjusts the config bytes we want to read depending on
> > > what kind of features we have, but we later cast the entire buf we
> > > read with "struct virtio_net_config", which is obviously wrong.
> > 
> > When describing a bug, it is important to explain what is the consequence,
> > i.e. which use case is failing. If it is only to prepare the new feature,
> > it is better to clearly state that the bug had no impact until now.
> > 
> > And as usual, the "fix" word in the title and the "Fixes" tag are required.
> 
> What's the right way supposed to use "Fixes" tag, BTW? Checking the git
> hisotry, I saw something like:
> 
> 	Fixes: $commit_hash ($commit_log).

In http://dpdk.org/dev, this git alias is recommended:
	fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")'

> Which basically means it's a regression fix. However, in this case, it's
> more than like a bug, but not a regression.

Referencing the original commit (introducing the bug) makes it clear.