From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] librte_pmd_packet: add PMD for AF_PACKET-based virtual devices Date: Fri, 11 Jul 2014 18:47:47 +0200 Message-ID: <4763701.40HJ79Bo5S@xps13> References: <1405024369-30058-1-git-send-email-linville@tuxdriver.com> <1669414.yQGOz8cIDY@xps13> <20140711153006.GC25478@tuxdriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "John W. Linville" Return-path: In-Reply-To: <20140711153006.GC25478-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-07-11 11:30, John W. Linville: > On Fri, Jul 11, 2014 at 05:04:04PM +0200, Thomas Monjalon wrote: > > 2014-07-11 10:51, John W. Linville: > > > On Fri, Jul 11, 2014 at 03:26:39PM +0200, Thomas Monjalon wrote: > > > > Thank you for this nice work. > > > > > > > > I think it would be well suited to host this PMD as an external one in > > > > order to make it work also with DPDK 1.7.0. > > > > > > I'm not sure I understand the suggestion -- you don't want to merge > > > the driver for 1.8? Or you just want to host this patch somewhere, > > > so people can still use it w/ 1.7? > > > > I suggest to have a separated repository here: > > http://dpdk.org/browse/ > > I really don't see any reason not to merge it. It was already delayed > by me waiting for all the PMD init changes to settle out in the 1.6 > release, and I still had to do a few touch-ups for it to compile on > 1.7. I definitely do not want to have to do that over and over again. It's a pity that we didn't synchronize our efforts to make it integrated during 1.7.0 cycle. > Why wouldn't you just merge it? If someone wants to use it on 1.7, > they can just apply the patch. I'm OK to merge it. I was only suggesting to host your PMD externally like we did for virtio-net-pmd, vmxnet3-usermap and memnic. It was the same discussion for the vmxnet3 PMD that Stephen submitted. I start thinking that nobody wants PMD to be external. So we may merge this one in dpdk.git and start talking what to do for the other ones: - move memnic in dpdk.git? - move virtio-net-pmd and vmxnet3-usermap where sits their uio counterparts? - merge Brocade's vmxnet3 as new one or as a replacement for vmxnet3-uio? -- Thomas