From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] ethdev: add new RX/TX queue state arrays in rte_eth_dev_data Date: Wed, 04 Nov 2015 17:53:15 +0100 Message-ID: <4777980.MR7QEg9ZTP@xps13> References: <1442440284-6175-1-git-send-email-pablo.de.lara.guarch@intel.com> <2601191342CEEE43887BDE71AB97725836A9B901@irsmsx105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "De Lara Guarch, Pablo" Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id DEEF78E9D for ; Wed, 4 Nov 2015 17:54:27 +0100 (CET) Received: by wmll128 with SMTP id l128so119479660wml.0 for ; Wed, 04 Nov 2015 08:54:27 -0800 (PST) In-Reply-To: <2601191342CEEE43887BDE71AB97725836A9B901@irsmsx105.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > Following the same approach taken with dev_started field > > in rte_eth_dev_data structure, this patch adds two new fields > > in it, rx_queue_state and tx_queue_state arrays, which track > > which queues have been started and which not. > > > > This is important to avoid trying to start/stop twice a queue, > > which will result in undefined behaviour > > (which may cause RX/TX disruption). > > > > Mind that only the PMDs which have queue_start/stop functions > > have been changed to update this field, as the functions will > > check the queue state before switching it. > > > > Signed-off-by: Pablo de Lara > > Acked-by: Konstantin Ananyev Applied, thanks