From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [RFC PATCH v1] rte: LCore heartbeat example Date: Tue, 15 Sep 2015 15:10:44 +0200 Message-ID: <4778653.jvL6ac5tEo@xps13> References: <1442319413-3614-1-git-send-email-remy.horton@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Remy Horton Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 7BC2E8E6C for ; Tue, 15 Sep 2015 15:11:52 +0200 (CEST) Received: by wicfx3 with SMTP id fx3so28019989wic.1 for ; Tue, 15 Sep 2015 06:11:52 -0700 (PDT) In-Reply-To: <1442319413-3614-1-git-send-email-remy.horton@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, 2015-09-15 13:16, Remy Horton: > Provides a basic framework for detecting and reporting live-ness of > LCores, the primary requirement of which is minimal overheads for the > core(s) being checked. Core failures are notified via an application > defined callback. As an example l2fwd with random failures is used. No it's not a framework, it's a sample application. If the feature is interesting, it must be integrated in a library. Then you need some doc, unit tests and an example to demonstrate its usage. Please try to use an existing example instead of creating a new one. Thanks