From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v5] devtools: add test script for meson builds
Date: Tue, 29 May 2018 17:37:59 +0200
Message-ID: <4779126.RJGVKi6kDl@xps>
References: <20180424123255.204330-1-bruce.richardson@intel.com>
 <20180529144243.9619-1-thomas@monjalon.net>
 <59AF69C657FD0841A61C55336867B5B072633423@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 2313C14EC
 for <dev@dpdk.org>; Tue, 29 May 2018 17:38:02 +0200 (CEST)
In-Reply-To: <59AF69C657FD0841A61C55336867B5B072633423@IRSMSX103.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

29/05/2018 16:58, Richardson, Bruce:
> 
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Tuesday, May 29, 2018 3:43 PM
> > To: dev@dpdk.org
> > Cc: Richardson, Bruce <bruce.richardson@intel.com>
> > Subject: [PATCH v5] devtools: add test script for meson builds
> > 
> > From: Bruce Richardson <bruce.richardson@intel.com>
> > 
> > To simplify testing with the meson and ninja builds, we can add a script
> > to set up and do multiple builds. Currently this script sets up:
> > 
> > * clang and gcc builds
> > * builds using static and shared linkage for binaries (libs are always
> >    built as both)
> > * a build using the lowest instruction-set level for x86 (-march=nehalem)
> > * cross-builds for each cross-file listed in config/arm
> > 
> > Each build is configured in a directory ending in *-build, and then for
> > the build stage, we just call ninja in each directory in turn. [i.e. we
> > assume every directory starting with "build-" is a meson build, which is
> > probably an ok assumption].
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> > v2: it is a rework with 3 major changes
> >    - automatically stop on error thanks to -e
> >    - directory name starts with "build-"
> >    - optionally load a config file to get some environment variables
> > v3:
> >    - remove forcing "cd": use current directory
> >    - remove CROSS: use hard-written aarch64-linux-gnu-gcc
> >    - remove config load in script start
> > v4:
> >    - remove config file loading (will be improved and sent later)
> >    - the v4 is closer to what Bruce sent as v1
> > v5:
> >    - specify srcdir to build from anywhere
> >    - use ccache for ARM
> > ---
> >  MAINTAINERS                   |  1 +
> >  devtools/test-meson-builds.sh | 46
> > +++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 47 insertions(+)
> >  create mode 100755 devtools/test-meson-builds.sh
> 
> LGTM

Applied, thanks