From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v3 1/2] net/i40e: queue region set and flush Date: Thu, 21 Sep 2017 16:45:54 +0100 Message-ID: <4783591b-6b19-bc5e-025d-0c2edce9c4ec@intel.com> References: <1505282644-40415-1-git-send-email-wei.zhao1@intel.com> <1505445188-70251-1-git-send-email-wei.zhao1@intel.com> <1505445188-70251-2-git-send-email-wei.zhao1@intel.com> <0508ed6a-4301-de07-7bb1-a74a5ff2a871@intel.com> <7de926e7-a81c-4cda-59a1-736acdd7cb63@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit To: "Zhao1, Wei" , "dev@dpdk.org" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 49E081B1AE for ; Thu, 21 Sep 2017 17:45:56 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/21/2017 8:26 AM, Zhao1, Wei wrote: > > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Thursday, September 21, 2017 3:10 PM >> To: Zhao1, Wei ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: queue region set and flush >> >> On 9/21/2017 7:48 AM, Zhao1, Wei wrote: >>> Hi, Ferruh >>> >>>> -----Original Message----- >>>> From: Yigit, Ferruh >>>> Sent: Wednesday, September 20, 2017 6:36 PM >>>> To: Zhao1, Wei ; dev@dpdk.org >>>> Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: queue region set and >>>> flush >>>> >>>> On 9/15/2017 4:13 AM, Wei Zhao wrote: >>>>> This feature enable queue regions configuration for RSS in PF/VF, so >>>>> that different traffic classes or different packet classification >>>>> types can be separated to different queues in different queue >>>>> regions.This patch can set queue region range, it include queue >>>>> number in a region and the index of first queue. >>>> >>>> Is following correct: >>>> So instead of distributing packets to the multiple queues, this will >>>> distribute packets into queue reqions which may consists of multiple >> queues. >>>> >>>> If so, is there a way to control how packets distributed within same >>>> queue region to multiple queues? >>>> >>>> And is this feature only supported with RSS? Can it be part of RSS >>>> configuration instead of PMD specific API? >>>> >>>>> This patch enable mapping between different priorities (UP) and >>>> >>>> User priorities (UP) >>>> >>>>> different traffic classes.It also enable mapping between a region >>>>> index and a sepcific flowtype(PCTYPE).It also provide the solution >>>>> of flush all configuration about queue region the above described. >>>>> >>>>> Signed-off-by: Wei Zhao >> >> <...> >> >>>>> + ret = i40e_aq_update_vsi_params(hw, &ctxt, NULL); >>>>> + if (ret) { >>>>> + PMD_INIT_LOG(ERR, "Failed to configure queue region " >>>>> + "mapping = %d ", hw->aq.asq_last_status); >>>> >>>> Please don't split log message. >>> >>> If I do not spli it , the line will has more 80 character, there will be warning in >> patch check log! >>> So, which way do you think will be better? Split or warning log? >> >> Checkpatch detects log lines and shouldn't complain about them. >> >> Even it does I thinks checkpatch warning is better, assuming reasonable >> length. >> >> And you can do as following to reduce the line length: >> >> PMD_INIT_LOG(ERR, >> "Failed to configure queue region mapping = %d ", >> hw->aq.asq_last_status); >> >> <...> > > Ok, I will change to that way, but there will be warning in patch check. > Because at first I do not split them, then after patch check, I find that I must eliminate these over 80 warning. If you are using devtools/checkpatches.sh script, it ignores the LONG_LINE_STRING warnings, so long log messages shouldn't be generating warning. I just confirmed it is working as expected.