From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v8 10/25] eal/pci: Helpers for device name
	parsing/update
Date: Wed, 31 Aug 2016 09:54:41 +0530
Message-ID: <4792de2f-e9f8-3eea-aed7-16f7fd9f1c83@nxp.com>
References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com>
 <1472219823-29486-1-git-send-email-shreyansh.jain@nxp.com>
 <1472219823-29486-11-git-send-email-shreyansh.jain@nxp.com>
 <3AEA2BF9852C6F48A459DA490692831F01075153@IRSMSX109.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "viktorin@rehivetech.com" <viktorin@rehivetech.com>,
 "david.marchand@6wind.com" <david.marchand@6wind.com>,
 "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>,
 "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam02on0044.outbound.protection.outlook.com [104.47.36.44])
 by dpdk.org (Postfix) with ESMTP id 478F52142
 for <dev@dpdk.org>; Wed, 31 Aug 2016 06:24:49 +0200 (CEST)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F01075153@IRSMSX109.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

On Tuesday 30 August 2016 10:04 PM, Pattan, Reshma wrote:
> Hi,
>
>> +/**
>> + * Utility function to write a pci device name, this device name can
>> +later be
>> + * used to retrieve the corresponding rte_pci_addr using
>> +eal_parse_pci_*
>> + * BDF helpers.
>> + *
>> + * @param addr
>> + *	The PCI Bus-Device-Function address
>> + * @param output
>> + *	The output buffer string
>> + * @param size
>> + *	The output buffer size
>> + * @return
>> + *  0 on success, negative on error.
>> + */
>
> This function doesn't have any return value. Need to change the @return description.

I will correct this in v9. Thanks for review.

>
>> +static inline void
>> +rte_eal_pci_device_name(const struct rte_pci_addr *addr,
>> +		    char *output, size_t size)
>> +{
>> +	RTE_VERIFY(size >= PCI_PRI_STR_SIZE);
>> +	RTE_VERIFY(snprintf(output, size, PCI_PRI_FMT,
>> +			    addr->domain, addr->bus,
>> +			    addr->devid, addr->function) >= 0); }
>> +
>
> Thanks,
> Reshma
>

-
Shreyansh


-- 
-
Shreyansh