From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 8/9] net/qede: use newer packet mbuf allocate
 API
Date: Thu, 29 Jun 2017 13:55:28 +0100
Message-ID: <47bf845e-61a1-14c2-428b-5a42864355d4@intel.com>
References: <1498729889-21524-1-git-send-email-rasesh.mody@cavium.com>
 <1498729889-21524-9-git-send-email-rasesh.mody@cavium.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Dept-EngDPDKDev@cavium.com
To: Rasesh Mody <rasesh.mody@cavium.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id EDA81377E
 for <dev@dpdk.org>; Thu, 29 Jun 2017 14:55:30 +0200 (CEST)
In-Reply-To: <1498729889-21524-9-git-send-email-rasesh.mody@cavium.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/29/2017 10:51 AM, Rasesh Mody wrote:
> Use rte_pktmbuf_alloc() API instead of rte_mbuf_raw_alloc().
> 
> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
> ---
>  drivers/net/qede/qede_rxtx.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c
> index 8063233..6b047a3 100644
> --- a/drivers/net/qede/qede_rxtx.c
> +++ b/drivers/net/qede/qede_rxtx.c
> @@ -16,7 +16,7 @@ static inline int qede_alloc_rx_buffer(struct qede_rx_queue *rxq)
>  	dma_addr_t mapping;
>  	uint16_t idx = rxq->sw_rx_prod & NUM_RX_BDS(rxq);
>  
> -	new_mb = rte_mbuf_raw_alloc(rxq->mb_pool);
> +	new_mb = rte_pktmbuf_alloc(rxq->mb_pool);

rte_pktmbuf_alloc() is more expensive call, because of
rte_pktmbuf_reset() it has.

Are you sure you want to switch, what is the motivation?

>  	if (unlikely(!new_mb)) {
>  		PMD_RX_LOG(ERR, rxq,
>  			   "Failed to allocate rx buffer "
>