From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v5 0/4] bnx2x: poll mode driver Date: Mon, 27 Jul 2015 04:09:01 +0200 Message-ID: <4802193.YkiD4yNaLb@xps13> References: <1437410000-15907-1-git-send-email-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Harish Patil , Stephen Hemminger Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id E5601C4BC for ; Mon, 27 Jul 2015 04:10:22 +0200 (CEST) Received: by wicgb10 with SMTP id gb10so91945145wic.1 for ; Sun, 26 Jul 2015 19:10:22 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > >Stephen Hemminger (4): > > eal: provide functions to access PCI config > > bnx2x: driver core > > bnx2x: driver support routines > > bnx2x: enable PMD build > > Acked-by: Harish Patil This driver is too big, its style do not comply with the DPDK coding style, there is no git history (drop all in 2 patches), there is no documentation, no BSD support and it has no maintainer. However, any new driver is welcome and can get a chance to live in the DPDK repository. That's why it has been applied. But next changes must be clean, even if it implies a big refactoring. In case its maintenance cause problems and no declared maintainer can help, it will be dropped. It has not been tested with all supported compilers. Please be prepare to fix the compilation shortly.