From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Chris Wright <chrisw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org,
Patrice Buriez
<patrice.buriez-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] kni: fixed compilation error on Ubuntu 14.04 LTS (kernel 3.13.0-30.54)
Date: Thu, 24 Jul 2014 17:25:07 +0200 [thread overview]
Message-ID: <4806739.tm6Yeut3DK@xps13> (raw)
In-Reply-To: <20140724152011.GB18804-SwUeJysX96B82hYKe6nXyg@public.gmane.org>
Hi Chris,
2014-07-24 08:20, Chris Wright:
> * Pablo de Lara (pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org) wrote:
> > Signed-off-by: Patrice Buriez <patrice.buriez-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> Just a mechanical nitpick on DCO. Pablo, this patch appears to be
> written by Patrice. If so, it should begin with "From: Patrice Buriez
> <patrice.buriez-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>" and should include your own Signed-off-by.
I agree that the author name (From:) should be fixed.
But I'm not sure we should follow Linux guidelines for Signed-off-by
when patch is simply forwarded. Does it mean more than "I am authorized to
send it" ?
--
Thomas
next prev parent reply other threads:[~2014-07-24 15:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 14:28 [PATCH] kni: fixed compilation error on Ubuntu 14.04 LTS (kernel 3.13.0-30.54) Pablo de Lara
[not found] ` <1406212131-22314-1-git-send-email-pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-07-24 14:54 ` Thomas Monjalon
2014-07-24 14:59 ` Thomas Monjalon
[not found] ` <8BBE948C60307D47AD16B5B5B92A387E32E1A2B4@IRSMSX106.ger.corp.intel.com>
[not found] ` <8BBE948C60307D47AD16B5B5B92A387E32E1A2B4-kPTMFJFq+rFT4JjzTwqWc7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-08-01 13:15 ` Thomas Monjalon
2014-07-24 15:20 ` Chris Wright
[not found] ` <20140724152011.GB18804-SwUeJysX96B82hYKe6nXyg@public.gmane.org>
2014-07-24 15:25 ` Thomas Monjalon [this message]
2014-07-24 15:43 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4806739.tm6Yeut3DK@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=chrisw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=patrice.buriez-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).