From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] bus/fslmc: update MC to 10.3.x
Date: Fri, 06 Oct 2017 01:34:09 +0200
Message-ID: <4808052.LEHOq8oruM@xps>
References: <1505558149-28884-1-git-send-email-hemant.agrawal@nxp.com>
 <1505558149-28884-2-git-send-email-hemant.agrawal@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, ferruh.yigit@intel.com
To: Hemant Agrawal <hemant.agrawal@nxp.com>, shreyansh.jain@nxp.com
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id ADB3A1B1A0
 for <dev@dpdk.org>; Fri,  6 Oct 2017 01:34:10 +0200 (CEST)
In-Reply-To: <1505558149-28884-2-git-send-email-hemant.agrawal@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

This is a huge patch without any comment!
It will be hard to find bugs in it when debugging in future.
And it will be also pointless to reference it in future fixes.
>>From a quality point of view, it is bad.

As it is touching only to dpaa2 stuff, it is accepted.
I do not want to be the one digging in it.
Please avoid such patch in future.

Applied