From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: [PATCH] config: remove useless lines for DPAA2 Date: Tue, 3 Apr 2018 15:13:06 +0530 Message-ID: <482ae28a-ef73-9bde-ae06-f9983aa2caec@nxp.com> References: <20180402220649.662-1-thomas@monjalon.net> <5df8c54e-a750-e576-9adb-50ff863872d3@nxp.com> <3161325.7B0DNJKXUk@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: hemant.agrawal@nxp.com, dev@dpdk.org To: Thomas Monjalon Return-path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40069.outbound.protection.outlook.com [40.107.4.69]) by dpdk.org (Postfix) with ESMTP id 351A21B690 for ; Tue, 3 Apr 2018 11:28:07 +0200 (CEST) In-Reply-To: <3161325.7B0DNJKXUk@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tuesday 03 April 2018 12:33 PM, Thomas Monjalon wrote: > 03/04/2018 08:55, Shreyansh Jain: >> On Tuesday 03 April 2018 03:36 AM, Thomas Monjalon wrote: >>> Some comments are not relevant in a config which only overrides >>> the default config. >>> >>> The option CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER is already disabled >>> by default so it can be removed from this file. >>> >>> Signed-off-by: Thomas Monjalon >>> --- >>> config/defconfig_arm64-dpaa2-linuxapp-gcc | 7 ------- >>> 1 file changed, 7 deletions(-) >> >> I think DEBUG_DRIVER should exist in local config so that a developer >> can easily toggle it without modifying the common_base, which should >> serves as repository rather than toggle. > > No, the file to be modified is .config in the build directory, > not the default config. In my environment I prefer changing the platform config rather than local .config as that way I can track changes through git. > >> I do see the problem that having an option in common_base and then >> having it again in local config without overriding (=n) - is non-intuitive. >> >> But, I still feel it is easier to control changes in local config - >> (make T=) is easily visible. > > It is not a local config file. > The local config is .config. Sorry, allow me to rephrase my previous wordings: s/local config/platform config/ Anyways, this is just my personal preference - not a big inconvenience. Thanks for the patch. Acked-By: Shreyansh Jain