From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mk: fix ABI versioning compile error for combined shared library Date: Mon, 02 Nov 2015 08:10:25 +0100 Message-ID: <4832819.EtRlJavyLu@xps13> References: <1706989.WgznurFLZ8@xps13> <4489406.qekDmzhmkY@xps13> <20151102000517.GA4669@sivlogin002.ir.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Eric Kinzie To: Ferruh Yigit Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 72E5A5A6B for ; Mon, 2 Nov 2015 08:31:39 +0100 (CET) Received: by wmff134 with SMTP id f134so52556697wmf.0 for ; Sun, 01 Nov 2015 23:31:39 -0800 (PST) In-Reply-To: <20151102000517.GA4669@sivlogin002.ir.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-11-02 00:05, Ferruh Yigit: > On Mon, Nov 02, 2015 at 12:24:51AM +0100, Thomas Monjalon wrote: > > > ifeq ($(LINK_USING_CC),1) > > > # Override the definition of LD here, since we're linking with CC > > > LD := $(CC) $(CPU_CFLAGS) > > > -O_TO_S = $(LD) $(call linkerprefix,$(CPU_LDFLAGS)) \ > > > +O_TO_S = $(LD) $(call linkerprefix,$(SHARED_LDFLAGS)) \ > > > -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE) > > > else > > > -O_TO_S = $(LD) $(CPU_LDFLAGS) \ > > > +O_TO_S = $(LD) $(SHARED_LDFLAGS) \ > > > -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE) > > > endif > > > > Why do you remove CPU_LDFLAGS? > > CPU_LDFLAGS shared by other libraries and confilicts with this usage. Sorry I don't understand. CPU_LDFLAGS is -melf_i386 for Intel 32-bit. Why removing it for combined library? What is the conflict?